Jordan Zucker
Jordan Zucker
Sorry, the new GitHub UI is awful, I thought I was opening this up on my local repo first. I wanted to test building on prs as well as releases
Wasn't discussed. I was trying to open this in my repo first, but GitHub's new PR UI is just awful and led me here instead. I couldn't track how the...
Did you try `http://plex` instead of `plex` for `SERVER_IP`? If so, is the result different then with just `plex`? It'd be helpful if you could share some logs, there should...
It doesn't seem like this builds anything but default images, which is likely `amd64` If it says 32 bit, you
You're entering a mDNS name. Have you tried getting the actual IP address of the NAS and using that instead? It should be something like `10.0.1.17` or `192.168.0.21`, or however...
Definitely seems like an improvement! Thank you! Over a longer period I had a cap on the docker compose but it was trending higher before Thanks again!
I know I'm missing docs, but I'm marking as ready for review as a quick sanity check on the direction of this PR, and happy to follow up with docs...
Signed! > Hi @jzucker2 > > It seems you haven't yet signed a CLA. Please do so [here](https://home-assistant.io/developers/cla_sign_start/?pr=home-assistant/core#113849). > > Once you do that we will be able to review...
I fixed up all the tests! I'm not quite sure what the preferred process for test helpers is but I think it needs a little clean up. Tests **do** pass...
Hi! Thank you for the earlier feedback. I added the labels (except for `zone`) and also updated the unit tests. It ended up being a huge effort to update the...