James Zhan

Results 36 comments of James Zhan

@xusir2 @songli0805 I got the same problem, solved by using this one https://github.com/archriss/react-native-render-html# painless transition

Hi @urugator what do you think about this PR? do you think it's safe to reintroduce the observability?

Hi @urugator thanks for the informative reply. > render callbacks accessing this.props/state/context should not force updates during render I tested your linked test case on my branch, it seems to...

Hi @dabit3 , I'm having the same issue, did you move to react-native-twilio-programmable-voice already?

Hi @mweststrate my PR won't have any effect on this as the PR is for class component only. for this issue, I spent some time to investigate. I believe this...

That's right, let me explain When a component needs to update (i.e. setState from useState hook is called), react schedule/enqueue an update then, react starts a render cycle, which consists...

hello @urugator I made some progress I made several changes to ObserverClass 1. as discussed above, reintroducing observable props state context 2. solved extra `shallowEqual` calls. because I stop using...

~~The main logic change is to remove admin.isUpdating and add `admin.pendingStateVersion` and `admin.stateVersion`~~ ~~when admin.pendingStateVersion is assigned a new symbol value, i.e. `admin.pendingStateVersion !== admin.stateVersion`. it means an update is...

Hi @urugator @mweststrate I'm keen to hear you thoughts, ~~I understand wrapping class component with function component is not a easy decision, but this is the only way to schedule...

~~Close this PR as I need to reorganise the changes~~ reopened