Jason Young
Jason Young
Per our Discord conversation, some suggestions for CAR combinations. These probably should have been merged all along, as they share a chassis code: * SEAT Leon and SEAT Ateca share...
> I'm fine with that. I think @adeebshihadeh wanted to double check the FW to ensure the brand from the VIN was correct(?), in which case we can assert the...
Released from draft, ready for review. I haven't received feedback from the end user yet, but this is a rare event that takes awhile to reproduce, and this is a...
> @jyoung8607 it is undecided for other ports whether to use latActive or enabled, what do you think, is this distracting to change when going into standstill? I think this...
VIN check verifies this is a Tucson, but there's a unit test that very specifically blacklists this Tucson's camera firmware. What is it we're supposed to do here? @sshane @sunnyhaibin...
Glad to hear it's functionally effective, but I intended for openpilot to stay silent (not alert about low speed) as well. There's one more alert I need to tweak. I'll...
@dukeajuke Check for updates and try it again, it shouldn't display the low speed alert anymore.
> @jyoung8607 I saw this PR and test this branch on my 2023 Kodiaq RS (Europe import to Taiwan). Kodiaq RS's EPS seems more critical than other VW cars. This...
@dukeajuke @Gyrohammer Have either of you tested the current version of this PR? Need your feedback to move forward.
Ready for review then! The process_replay difference is expected, due to the updated minSteerSpeed parameter. ``` ***** results for segment regen8BDFE7307A0|2023-10-30--23-19-36--0 ***** controlsd ref: https://commadataci.blob.core.windows.net/openpilotci/regen8BDFE7307A0|2023-10-30--23-19-36--0_controlsd_7d25b1f7d0bd3b[506](https://github.com/commaai/openpilot/actions/runs/7922952955/job/21631686752?pr=31450#step:6:507)fa4e72ff893728894eb1a45.bz2 new: /tmp/openpilot/openpilot/selfdrive/test/process_replay/fakedata/regen8BDFE7307A0|2023-10-30--23-19-36--0_controlsd_2d6a36ff6533c71bebd31bacc13c9f89f7286bfe.bz2 carParams.minSteerSpeed: 2 radard...