Jiewen Yao comments

Results 199 comments of


                                            Jiewen Yao

Add UEFI target support

@briansmith, would you please review this patch to see if there is any other comment?

Add UEFI target support

This has been there for half a year. @briansmith, would you please review this patch to see if there is any other comment?

Add support for verifying certificate chain with EKU

@briansmith, would you please review this patch to see if there is any comment?

All functions that access the cryptography module need to return libspdm_return_t

This seems incompatible change. I think we can fix in this 2.0.0. Do we have a list?

Have certificate parsing and processing be its own library

I think we should also separate the PEM parsing and processing.

Move low-level crypto API away for OpenSSL 3.0?

Is this for openssl 3.0? We have POC - https://github.com/DMTF/libspdm/tree/openssl_3.0.2_eval. (backup to https://github.com/jyao1/libspdm/tree/openssl_3.0.2_eval) If you can keep the library API as is, then I am open to change the implementation....

Move low-level crypto API away for OpenSSL 3.0?

We need openssl 3.0.7 at least, where a high issue is fixed. Ref: https://www.openssl.org/news/openssl-3.0-notes.html, and https://www.openssl.org/news/vulnerabilities.html

test_size_of_spdm_requester dosent works on Linux

It is OK to turn on for GCC, if you have send a PR. (it is just not enabled before.) The MSVC data is shown at https://github.com/DMTF/libspdm/discussions/603. 1.2K is too...

test_size_of_spdm_requester dosent works on Linux

Sorry, I thought it is 1.2M. 1.2k is too small, definitely. Just checked the code, I use ``` #if defined(_MSC_EXTENSIONS) #pragma optimize("", off) #endif ``` I think we may need...

test_size_of_spdm_requester dosent works on Linux

270K is full feature + no encryption? that is big. Maybe you can help check the symbol to see if any unnecessary functions are included.