Jonathon

since making this pull request, I have been doing all my coding in my own fork of neovim with these changes and some additional ones related to diff mode. When...

> Is there a reason this cannot also be PR'd to vim? I've looked at the relevant vim source code it is pretty easy to apply the patch to vim...

it's rebased to current master and it seems to work, I'll use it all day it tomorrow to make sure everything is working and might take a look at using...

I'd prefer not to call the linematch algorithm inside diff_file_internal (xdl_diff wrapper) for a few reasons 1. there's a lot of conditional logic on when it will be run starting...

I've used a lot of recursion to make a generalized algorithm that works for diffs of both 2 files and 3 files, and theoretically it should work for 4 or...

How does this look for writing the files to a buffer and passing an array of buffers to the algorithm, rather than just the diff_T struct. https://github.com/neovim/neovim/blob/94131aa19dc9b830a0f3c15f94ab1767c9b185c0/src/nvim/diff.c#L2357-L2384 This is optimal?...

the current version in this PR (b0cf3d712) has been modified to use no neovim specific functions / structs inside the algorithm (diff_T, ml_get_buf). the algorithm takes char pointers and integer...

I found that I had some out of bounds memory access with strings, and I fixed that in the latest commit. Is there a good way to test for out...

I had another out of bounds memory access that I found and fixed with -DCLANG_ASAN_UBSAN=ON. now, there's no reported out of bounds access. the pull request is now open in...

> > also I'm considering moving all of the functions that are only used for the > > linematch algorithm to a separate file, like how the xdiff algorithm is...