JW
JW
hmm I don't know how much work it will take to clear all the errors. My original plan was to make the 1.2.0 release then do the clang-tidy work.
Sorry for the delay. The change is made and is passing CI and we will be pushing @eli-schwartz your suggestion (https://github.com/bcgsc/abyss/tree/tlo ) to master once we have checked the assembly...
Processing CI issues related to the PR
Done. See #479
We opted to use `lib/btllib/python/` as the default installation path because in HPC environments you often don't have access to `usr/bin`. `btllib` has `--prefix` parameter to change the installation path.
Yeah that would be my approach too. The new class checks the phred sum / avg and rolls the nthash iterator as necessary. Are you thinking of template because of...
> > Are you thinking of template because of seednthash? > > Yeah basically I was thinking that since we have four ntHash classes, it'd be unusual to have a...
> > > > Are you thinking of template because of seednthash? > > > > > > > > > Yeah basically I was thinking that since we have...
Hi, That should not be happening. The `sdsl` library is included via `isystem` which should suppress the warnings (see https://github.com/bcgsc/btllib/blob/master/meson.build#L60). Perhaps some settings on your end are overriding it.
Thanks for your interest in using GoldRush. I've double checked with the most recent version of GoldRush using the test script. To further aid us in helping resolve your issue....