HowProgrammingWorks
I have question
Does it matter how to call inherited method such as Array.prototype.pop(), through inherited array.pop() or Array.prototype.pop.call(array) ?
clang-tidy should ignore the fileTests/Unit/catch.hpp because it's vendored. You could move it to a subdirectory of vendor/.
This PR must pass CI before merging. One way to do that is to make the necessary fixes to silence the clang-tidy errors. Another option is to ignore the failure of the clang-tidy errors in the Makefile. The former solution is preferable.
clang-tidyshould ignore the fileTests/Unit/catch.hppbecause it's vendored. You could move it to a subdirectory ofvendor/.
I'll do this in a separate PR since I'll have to change the regex for the clang-format too. I didn't catch was vendor library too.
hmm I don't know how much work it will take to clear all the errors. My original plan was to make the 1.2.0 release then do the clang-tidy work.