Josh Watzman comments

Results 26 comments of


                                            Josh Watzman

xformers, Expected query.dim() == 3 to be true, but got false

What version of xformers are you using? I had the same problem with 0.0.13, but I upgraded to a 0.0.14-dev build (commit faa88b123514562dbe8e32ec72a25937b0dd9da5) which resolved the issue. I've been building...

Error running the Notebook on sagemaker with sd 1.5

Typically "Killed" means "you ran out of RAM" (not VRAM, normal RAM). How much RAM does this machine have? Since it sounds like you're running this on a cloud machine,...

Error running the Notebook on sagemaker with sd 1.5

The desktop I've been using for SD/Dreambooth also has 16 GB of RAM, and it is *barely* enough if I give it significant swap space and run nothing else. I...

local use setup guide?

I was able to get it to work by reading through one of the notebook files, e.g., https://github.com/JoePenna/Dreambooth-Stable-Diffusion/blob/main/dreambooth_colab_joepenna.ipynb and recreating locally what it was doing. This is relatively straightforward if...

training gets "Killed" ? not sure why

For anyone running into this for which the above doesn't help, this can be caused by a number of things, but the most likely is due to the machine running...

Patch is unrecognized if it is for a version prefixed with a 'v'

I managed to work around the issue I was going to patch a completely different way so I haven't tested this let alone put up a PR -- but skimming...

strict mode inconsistent: needs typehints for global constants, not for class constants

I think we'll automatically infer `UNTYPED_CONST` as int (which we can do due to the limited number of things you can put in the RHS of a const). We don't...

Runtime should disallow 'async public function' or typechecker should allow it

I don't feel super strongly, but I like consistency, and forcing "async function" to always be together. So I'd say we should ban it in HHVM.

Allow whitelisting unrecognized __Foo attributes with user_attributes= in .hhconfig

@elgenie what do you think? This could be useful for forwards-compatibility.

Add <<__DoNotCallTwice>> attribute or similar

I'm not convinced that this is a common enough pattern to be worth the effort? Could be wrong though. Also while the runtime semantics are clear, I'm not totally sure...