Jiuyun Wang
Jiuyun Wang
Yes, any update from Microsoft? If they don't have plan to do so. Can we fork a branch and add Azure enhancements on our own?
Looks like there is deadlock which cause cpu to go 0 and app freezes.
It seems that it is missing the lockguard/unique_lock in two places: m_conditional_lock.notify_all() and m_conditional_lock.notify_one()
The code seems a bit complicated. What's spurious wakeup case, do you mind elaborating a little bit on it? https://stackoverflow.com/questions/17101922/do-i-have-to-acquire-lock-before-calling-condition-variable-notify-one also: https://thispointer.com/c11-multithreading-part-7-condition-variables-explained/
You can also refer to this example: https://github.com/vit-vit/ctpl, which is working, but a bit slower.
It looks to me the bug is in line 32: m_pool->m_conditional_lock.wait(lock); Here it needs to check certain condition is met or not to tell whether it is spurious wake up...