Jyrki Muukkonen

Simplistic patch here: https://github.com/jvtm/redis-rdb-tools/tree/lzf-speedup Not creating a pull request just yet, I want to test this with real fresh dumps first. The related unit tests pass, but I didn't check...

Wow, didn't even remember this one... Not working anymore on the project where this was required. Here's the exact tiny commit: https://github.com/jvtm/redis-rdb-tools/commit/fdd8134bed488462d0bfae449b542bb3d611f7d3 (failed to include this issue in commit message)

Discussion in https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/677 pointed out that _zero length strings_ are actually valid in the scope of given RFC's. So, my initial easy PR needs a bit more work. As the...

@Julian I think the easiest patch for now is to do a fast pre-check / `return True` on special cases on `jsonschema`, before calling the external libraries. Something like ```py...

And then there is the Python standard lib `idna` encoding... oh my :exploding_head: ``` >>> "hello".encode("idna") b'hello' >>> "hello.".encode("idna") b'hello.' >>> "".encode("idna") b'' >>> ".".encode("idna") Traceback (most recent call last):...

``` (Pdb) pprint.pprint(request.node.own_markers) [Mark(name='usefixtures', args=('monkeypatch',), kwargs={}), Mark(name='network', args=(), kwargs={}), Mark(name='slow', args=(), kwargs={}), Mark(name='usefixtures', args=('monkeypatch',), kwargs={}), Mark(name='network', args=(), kwargs={}), Mark(name='slow', args=(), kwargs={}), Mark(name='asyncio', args=(), kwargs={})] ```

Uhh, what a can of worms.. ;) Some docs here and there limit DNS labels to be 1-63 octets (and some 0-63), and full entry max 253. But no mentions...

I'll reverse the check and reword the commit and PR later today. Is it worth adding any other checks?

Looks like in Python `jsonschema` `idn-hostname` for both zero length string and a single dot fail. The check uses `idna` library https://github.com/kjd/idna/blob/8c703c782bf8144091c63470fcdbf29ac47eeb15/idna/core.py#L340-L370

I don't have time to work on this at the moment. I can see that there's some interest, and in theory the tests should be strict, but I'll leave that...