Joshua Van Deren

Results 20 comments of Joshua Van Deren

I have this repo where I rewrote compare-versions in typescript. If you want to take any inspiration from it, feel free to use anything: https://github.com/jvanderen1/compare-versions

I went ahead and published [@jvanderen1/compare-versions](https://www.npmjs.com/package/@jvanderen1/compare-versions)!

The diffing on src/index.js got affected by prettier it seems. If this is an eye-sore, I can remove the prettier changes from this file 👍🏻 .

@ryansolid Is there anyone you'd recommend to review this?

@ryansolid Yeah, I agree. I will remove the `prettier` change in `index.js`. Maybe in a different PR, we could introduce linting/prettier rules to run on every commit. This can be...

@ryansolid I pushed out `index.js` without `prettier` changes. Lmk if there's anything else 👍🏻 .

Can someone please merge this? @pcholuj @promanski

Having explicit instructions are always favorable than leaving out details. I would push for a change like this: 1. For user's newer to git, they may not know where to...

I wonder if this could also be achieved within PGSync's plugin API? That way, conditions can be more expressive. Something like: ```python3 from pgsync import plugin class FooPlugin(plugin.Plugin): name =...

I don't think an API exists today for something like this. However, it could be an enhancement.