Jannis Vamvas
Jannis Vamvas
:+1: As a reader, I would find the abstracts a great aid, too. Let me know if there is a way for me to help out.
This PR is now ready for review. Uploaded models: - https://huggingface.co/jvamvas/xmod-base - https://huggingface.co/jvamvas/xmod-large-prenorm - https://huggingface.co/jvamvas/xmod-base-13-125k - https://huggingface.co/jvamvas/xmod-base-30-125k - https://huggingface.co/jvamvas/xmod-base-30-195k - https://huggingface.co/jvamvas/xmod-base-60-125k - https://huggingface.co/jvamvas/xmod-base-60-265k - https://huggingface.co/jvamvas/xmod-base-75-125k - https://huggingface.co/jvamvas/xmod-base-75-269k
@younesbelkada Thank you for the swift code review, much appreciated! I have now implemented your comments.
@sgugger Thanks for the review. Your suggestions have now been implemented
@ArthurZucker Thanks for the code review. I have now implemented the changes you requested. I agree that the models should be moved to the [facebook](https://huggingface.co/facebook) organization but do not have...
Hi @ArthurZucker, thanks for pointing out that there are missing tests in this PR. Unfortunately, I have not been able to figure out which tests are missing, exactly. As of...
@younesbelkada Sorry about the bad rebase. On the plus side, the tests are now passing again :tada:
@ArthurZucker Done. The failing test is not related to this PR
Thanks for the report, @oesah! We will look into this
Looking at the way empty values are currently stored in the database, I suggest the following hack: `object.queryset.exclude(position='None')`