Justyn Butler

Results 24 comments of Justyn Butler

Perhaps I misunderstood the purpose of this action? I had thought it was to expose results of tests (or other operations) in the Github checks results. For example, I expected...

Ah okay the link shows what I was expecting (more or less). In the run I [linked to in the issue]( https://github.com/LouisBrunner/checks-action/actions/runs/220658890), that isn't happening, which is what prompted my...

No worries, thanks for your help, and thanks for publishing this action!

Ctrl-/ for strikethrough also doesn't work for me with Dvorak layout. I'm not sure why, the other shortcuts I've tried seem to function correctly.

On Ubuntu 19.10 I've also found that the current master branch (3afc470), built with `npm run deploy:linux-x64` is not showing the system tray. Building tag v1.5.4 does show the system...

I wonder if it could be related to this: https://github.com/electron/electron/issues/21445

@Werni2A that is a great point, I can't believe I didn't spot that. However, the same applies to the existing [1.5mm Pico-Lock 504050 parts](https://www.molex.com/pdm_docs/sd/5040500291_sd.pdf). Their pin numbering is also reversed...

I've tentatively pushed a new commit to fix the ordering on these (2mm) parts to match the datasheet, but probably a plan for the 1.5mm parts is needed before this...

chschlue [indicated](https://github.com/KiCad/kicad-footprints/issues/2465#issuecomment-691679864) that the incorrect ordering on the 1.5mm parts is a severe bug, I have submitted fixes to the script values [here](https://github.com/pointhi/kicad-footprint-generator/pull/628) and the footprints [here](https://github.com/KiCad/kicad-footprints/pull/2466). I assume then...

I've updated the screenshots to reflect the new rotated footprints with fixed pin numbering.