Justin Tadlock

Results 84 issues of Justin Tadlock

**Warning:** We need sniffs that check metadata. Currently, the theme review team allows themes to have metadata if it is presentational in nature. Some common examples: * Sidebar position *...

low priority

Now that we have a couple of official feature packages, we should start thinking about long-term maintenance for theme authors. If theme authors are using our packages, we want to...

Otto brought this up in Slack (https://wordpress.slack.com/archives/themereview/p1470952005002504), but it's long been one of those things that we wouldn't allow. Basically, themes should not be attempting to find and load the...

help wanted
issue: needs PR

Short PHP ` // vs. ``` Reference: * http://php.net/manual/en/ini.core.php#ini.short-open-tag * http://php.net/manual/en/function.echo.php

Theme Sniffer is erroneously requiring several theme files on https://github.com/WPTRT/theme-sniffer/blob/master/src/callback/class-run-sniffer-callback.php#L783 **comments.php** This file is not required. What's required is a call to the `comments_template()` function, which can reference any file...

Type: Bug
Status: PR Exists

I saw this briefly mentioned in [another ticket](https://github.com/WPTRT/theme-sniffer/issues/85#issuecomment-381414951) but thought it'd best to bring up as a standalone ticket. It'd be awesome if theme authors could define their own rulesets...

Type: Enhancement
Status: Future Release

**Update:** - JSON file is here: https://github.com/justintadlock/tt3-rough-draft/blob/master/theme.json - Raw: https://raw.githubusercontent.com/justintadlock/tt3-rough-draft/master/theme.json ~~Like its title, this variation is still very much a _rough draft_. However, I wanted to go ahead and share...

[Type] Style Variation

When a theme uses the featured image in its single post template, it runs the risk of creating the "duplicate featured image problem." This happens when a user also adds...

[Type] Enhancement

One thing that we should probably decide early on is what system to use for building compiling assets and so on. This project has minimal CSS and JS, so we...

help wanted
question

When a post is sticky, we need to add a class for it.