Justin Moon

Results 228 comments of Justin Moon

And maybe mention including a GPG pubkey in your first PR

Also, it seems like the [bitcoin/contrib/gitian-build.py](https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-build.py) script can simplify some of this stuff. For instance, this one command will build and sign both the signed and unsigned executables. ``` ./gitian-build.py...

`gitian-build.py` makes two nice little commits as well ... on `master` though ... ![Screenshot from 2020-12-26 00-11-53](https://user-images.githubusercontent.com/4335621/103146446-05a96080-470f-11eb-8df0-689b6de38753.png)

The downside of `gitian-build.py` is that since it does everything, when if fails you need to start all over. So not sure if it actually helps.

Perhaps you already had nasm / clang installed? The instructions don't mention them, and both seem to be required to build the examples.

No. This is what my `esy.lock` folder looks like: https://gist.github.com/justinmoon/ce76e4635529b837524a19cc609c0569 Here's a tarball of that directory in case that helps: [esy.lock.tar.gz](https://github.com/revery-ui/revery/files/4202604/esy.lock.tar.gz)

Here's the [index.json](https://github.com/revery-ui/revery/files/4202613/index.txt). Had to upload as index.txt b/c GitHub wouldn't allow a `.json` extension ...

But it seems the "module import example" does work: https://patleeman.github.io/quill-markdown-shortcuts/module/

For anyone using Create React App (can't edit webpack config), [this will fix it](https://github.com/facebook/create-react-app/discussions/11278#discussioncomment-1290846)