justinfrevert
justinfrevert
@HashWarlock was just asking me the other day about a code example for this. I think a code example, or a step-by-step implementation guide would pre-empt a lot of questions....
I would love to see this 🤞
How does the migration do on the production data? I was curious if this is subject to similar issues to the one we saw on the last fpass migration
Hi Felix, I think this wasn't a part of Root since its inception. Ultimately, this list can be unbounded, and result in a query that is unreasonably large. Thus, we've...
Slight correct to my previous comment - there isn't an unbounded response length to this one, I was thinking of another case which is super similar and being looked at...
Since we're refactoring, what do we think about the naming of `pallet/eth-bridge/src/ethereum_http_cli.rs`, I always had a kinda nitpick that `cli` is in the name, but it's a mod. Not sure...
I think it's looking good so far. Just a few comments
> > Since we're refactoring, what do we think about the naming of `pallet/eth-bridge/src/ethereum_http_cli.rs`, I always had a kinda nitpick that `cli` is in the name, but it's a mod....
Looking good so far. I think it would be good to address some of the comments and do the upgrade testing, then will probably take another glance.