Junkil Park

Results 22 comments of Junkil Park

I am planning to add this feature this after this PR (https://github.com/move-language/move/pull/291) lands. After the PR, Move CLI run the doc builder by the new subcommand `$ move docgen`. @gregnazario,...

> The historic reason why we had it in daily instead of CI were flakes in the DPN verification. Another reason was that the inconsistency check is 10x ~ 20x...

Yeah, the test case can have two ways to fail for the inductive case. One is by assigning `x`, and another is assigning `y`. Perhaps, we need to update the...

> Just to ensure: Do I need to add the changes in the `doc` directory to the commit content? Yes, the source files and the generated doc need to be...

It seems that there is a lint test failure in CI. It complains about trailing whitespaces. Could you fix it? Also, The new Move commit update (https://github.com/aptos-labs/aptos-core/pull/5380) just landed which...

@villesundell, thanks for this bug report. The expected output is that Prover produces an error with the message "bit operation not supported" because Prover does not support bit operations currently....

> So, would the next course of action be, that I will move the test back to daily and fix it properly? ( @wrwg & @junkil-park ) @villesundell , can...

Here is a PR to migrate the existing upgradability doc into the Move Book: https://github.com/aptos-labs/aptos-core/pull/7346 as the first step to improving the upgradability documentation.

The command to install the graphviz dot has been included in the `prover_setup.sh` script: https://github.com/aptos-labs/aptos-core/blob/main/developer-docs-site/static/scripts/prover_setup.sh#L352