Junha Yang(양준하)

Results 18 comments of Junha Yang(양준하)

Verifying header chain itself (aka header sync) can be reused in may places. For example the light client. So it would be better if we make separate module out of...

@majecty In which case is this new condition helpful?

This is not a short-term goal. I'll complete v0.1.0 without much consideration of this, anyway.

![Screenshot from 2020-09-22 17-06-34](https://user-images.githubusercontent.com/40292261/93857725-01c40780-fcf6-11ea-9288-3773af822b51.png)

@majecty We've already used procedural macros, but the point is that it's limited in very simple cases. For example we can't use it on any struct that has a tuple...

![Screenshot from 2020-01-14 12-21-15](https://user-images.githubusercontent.com/40292261/72311562-730fdd00-36c8-11ea-85a5-5e3a9efe398f.png) These (not all displayed) are either: 1. Can be directly removed using `#[derive]` 2. Can be removed if we solve this issue 3. Requires very specific...

We just decided to keep this opened after some discussion with @kseo. It doesn't seem to be important right now but is worth it enough to stay opened and be...

@majecty I think calling those methods for already shutdown port is a bug, not an error to handle.

@majecty I thought `shutdown()` taking `self` it natural, and I didn't understand why does Seulgi thinks it should take `&mut self`.