Julien Semaan

Results 149 comments of Julien Semaan

@jrouzierinverse, can you do another round of review with @fdurand's latest comments

Marking this for 12.0 so we at least discuss it prior to the release although we may decide to postpone this matter since it will not affect upgrades for applying...

A potential solution I thought of: The pruning process could untag all the images that aren't tagged with TAG_OR_BRANCH_NAME from conf/build_id and then run the docker prune which should clean...

I believe this has been addressed but we forgot to close it. Can you confirm @nqb?

I thought this should be handling it? https://github.com/inverse-inc/packetfence/blob/devel/containers/manage-images.sh#L71-L74

@nqb will start to look at implementing the cleanup The cleanup process will remove all images containing `packetfence` and that don't match the current build tag

Wouldn't this cause an issue if you try to rebuild the docker image of the portal on the PF server? Like to add some debug or adjust the style

Pushing to 12.2 since it's still missing a rebase and the feature freeze is active

There is 'Auto Enable' that can be toggled off too

I'm closing this since it exists. @nqb, feel free to reopen if our solutions aren't accurate