Julian Libiseller-Egger

Results 13 comments of Julian Libiseller-Egger

Thank you! Are there performance implications to be expected?

Makes sense. No, it was a custom .Rtab file.

Ah, I didn't realise that this usually wouldn't happen due to the MAF filters. Thanks for clarifying!

Regarding unit testing: After the change, all tests passed. Should we / I write new tests or rather change the `tests/presence_absence.Rtab.gz` file to include some missing values and adapt the...

Sorry for the delay! I added a simple unit test now.

When looking at the code I realised that missing values are always replaced by `0`s regardless of file type (as far as I can tell). Is this intended? Otherwise, AF...

I see. I can't say that I understand all the edge cases and how they are handled in the code. However, there is also https://github.com/mgalardini/pyseer/blob/1359b614491bca96264d9bd8e6535ec90a3cbedf/pyseer/input.py#L486 which removes samples from the...

I got a question along similar lines and a quick google search didn't really turn up anything useful: Do the reads need to strictly start at the same position or...

same for me on Manjaro 5.13.19-2