Julian Miller
Julian Miller
Given the complexity of the indexing changes and the limited user benefits, I think it's best to postpone this to the 2022.7 release.
> @julianmi, how do you think, should we introduce some type for the `union` > > ```c++ > union __storage > { > _Tp __v; > __storage() {} > };...
> > There might be potential benefits of utilizing 32-bit addressing on other algorithms as well. > > I agree with this, but I also feel like this may be...
Thank you for reporting this, @abagusetty. This is a known compiler issue. Please try with a compiler build after 20230822.
@AidanBeltonS Please rebase this PR off main to resolve the conflicts.
> > I copied my feedback from the original PR ([AidanBeltonS#30 (comment)](https://github.com/AidanBeltonS/oneDPL/pull/30#issuecomment-1850441506)) since it is still relevant: > > I think this is a good addition. We had a similar...
@AidanBeltonS Please rebase this since https://github.com/oneapi-src/oneDPL/pull/1410 has been merged. I think we can get this merged after the rebase and testing.
FPGA emulation CI seems to time out. @SergeyKopienko do you know why?
Couldn't we simply increase the timeout in our CI? One downside I noticed in this approach is the increased CI time (13 vs. 10 minutes for DPCPP backend on Linux...
I think the main issue motivating this PR was the test timeouts observed in https://github.com/oneapi-src/oneDPL/pull/1653. These had nothing to do with the test setup but was a bug introduced in...