Juan Pablo Cordero

Results 10 comments of Juan Pablo Cordero

Is there a standard format for N-body simulations outputs that would make this feasible?

I've added a notebook with some detailed explanation of how the functions are built in this enhancement to the projected-ellipticity repository (private) https://github.com/skypyproject/projected-ellipticities/blob/master/Dust-extincted%20ellipticity%20model.ipynb I'm not sure the unit tests I...

Are you suggesting we remove the tests from the docstrings entirely?

Just had a chat at the SkyPy meeting. In essencem, this PR models ellipticity as a function of extinction, while what we really want is a model for extinction as...

@jsun thanks for the comments. I'll provide a more comprehensive response soon. @crvernon Regarding the last bullet point: In general, is it okay to push significant changes to the main...

Hi @crvernon @jsun has made a few suggestions on the documentation and software paper which we have been addressing. Simultaneously we have been working on one of the main functionalities...

@kanishkan91 Thanks for the review! I'll start working on the issues as soon as posible.

Hi @crvernon, @jsun and @kanishkan91 Once again, thank you very much for your comments and suggestions. These have helped us improve the accessibility to the existing documentation, the examples and...

@jsun I have updated the manuscript. - Made a few changes to the summary to make it more concise. - Added a features section. Also rewrote a few paragraphs to...