Jim Turner

Results 120 comments of Jim Turner

As an idea, it may be helpful to add a hook so that users can more easily customize which files to ignore (with more sophisticated logic than just regexps). Personally,...

Thanks for the PR. I agree that it may be worth adding `Index` implementations for `Vec` and `&Vec`; there isn't much downside. Alternatively, we could add implementations for `Vec` and...

Two PRs will resolve this: - Conversions from owned types: #1028 - Conversions from slices/references: #1038

Status update: * ~`.remove_axis()` has been deprecated, and we shouldn't add an in-place variant of it.~ * `.insert_axis_inplace()` (in-place variant of `.insert_axis()`) was added in #537. * `.index_axis_inplace()` (in-place variant...

Okay, yeah, leaving it on `DataOwned` would be fine. We'd still add an `A: Clone` bound, and drop the "without any copying" guarantee. `OwnedRepr`, `OwnedArcRepr`, and the `Owned` variant of...

See the [docs for the `Index` implementation](https://docs.rs/ndarray/0.15.3/ndarray/struct.ArrayBase.html#impl-Index%3CI%3E), which indicate that the index needs to implement [`NdIndex`](https://docs.rs/ndarray/0.15.3/ndarray/trait.NdIndex.html). The [`NdIndex`](https://docs.rs/ndarray/0.15.3/ndarray/trait.NdIndex.html) provide a list of the implementations. The relevant ones for your case...

> ArrayRef is hopefully coming in 0.16. I don't know if these conflict, but I suggest that these changes have to stand back if they can't be realized in the...

> we need to think about release management. It turns out that Rust 1.31 will fix this for us, because 1.31 [stabilizes the `rename-dependency` cargo feature](https://github.com/rust-lang/cargo/pull/6319/) (see [cargo docs](https://doc.rust-lang.org/beta/cargo/reference/specifying-dependencies.html#renaming-dependencies-in-cargotoml)), which...

> Is it viable for nalgebra to implement conversions to our types? Do you mean conversions *from* our types? Not all conversions are possible without copying the data because `nalgebra`...

[`ArrayD`](https://docs.rs/ndarray/0.15.3/ndarray/type.ArrayD.html) supports arbitrarily many axes. Is it sufficient for your needs?