James Treanor

Results 12 comments of James Treanor

This could be solved in a few ways: 1. Allow whitelisting of UIViews to be affected by the swizzle. For complex apps it is not unusual to want `DAKeyboardControl`'s features...

Thanks, @malinajirka! Yes, that's right, this first appeared in 12.1-rc-3 which included these changes (the crash fix was one of them): - https://github.com/wordpress-mobile/WordPress-Android/pull/9492 - https://github.com/wordpress-mobile/WordPress-Android/pull/9500 - https://github.com/wordpress-mobile/AztecEditor-Android/pull/801

Thankfully, the crash rate has not grown over the weekend. As it stands I would be happy to cautiously push forward with the 12.1 release, while watching very carefully that...

Thanks, @daniloercoli and @mzorz. I would prefer not to catch and hide the crash. Without I fix, I think it is best to let the crash happen. Let's watch the...

Thanks everyone for the input on this. 12.1 has been rolling out gradually since Monday and the good news is that this has not been a widespread issue as of...

Yes, I agree. This refers to a simple change in the generated podspec only.

Thanks for the quick response @orta! I hadn't consider using Github Actions for Danger. That could be a great use case. Is there an established way of using Github Actions...

Ah, interesting. I'm OSS only too (I work on WordPress mobile) so that limitation would probably apply to me also. Thats good to hear that Peril is still actively used....

This is something that would also be very useful for our use case. We require all pull requests to have a milestone, but if a PR is opened without one,...

Any update on whether this or #25 will be accepted?