Jatan Buch
Jatan Buch
Hi @slayoo sure thing! Let me know what I can do to run these tests. Edit: I figured out the pre-commit test from the FAQ [here](https://github.com/open-atmos/python-dev-hints/wiki/Pre-commit-FAQ) but still slightly lost...
Ah I think I understand what's going on. Will post another commit on Monday after cleaning up the code a little.
Sounds good, @slayoo! I will update this within the next week.
@slayoo Thank you for the suggestion! I am trying to set up multiple branches for different cases (keep an eye out for more issues 👀) and I will rebase before...
Hi @slayoo I've added a new function locally that tests for both x- and z-directions based on the existing one in https://github.com/open-atmos/PySDM/blob/main/tests/unit_tests/initialisation/test_spatial_discretisation.py#L42-L57 Is there a file that calls `test_spatial_discretisation.py` where...
Ah that link was quite helpful, thanks! I have added the unit test to the repo now after verifying that it works locally.
Hi @slayoo, I finally got around to running the example and reading the code in more detail. Your implementation of a buffer of super-droplets is quite elegant and much more...
> codecov reports that the only single line missing test coverage is now (`particulator.py`): > > ```python > + if n_null == 0: > + raise ValueError( > + "No...
Just ran the code and everything looks good to me!
> Something looks odd to me in the plot of superdroplet count over time for the seeding vs. no seeding case. Why in the seeding case is the sd count...