Siyu Jiang (See-You John)

Results 28 comments of Siyu Jiang (See-You John)

That might not be trivial.. We will think through internally.

There was a BASE_GOERLI [PR](https://github.com/Uniswap/smart-order-router/pull/472#issuecomment-1889678091), that was closed due to not sufficient LP liquidities. Can you add LP liquidities on BASE_SEPOLIA?

> @jsy1218 I saw there's also no liquidity on Ethereum Sepolia for ETH/[USDC](https://sepolia.etherscan.io/address/0x1c7D4B196Cb0C7B01d743Fbc6116a902379C7238) > > What would be the min requirements to move this forward? Is 1 ETH/USDC (0.3%) LP...

@julien51 will take a look. sorry for the trouble.

We are working on perf optimizations over the last week. Do you see any noticeable perf improvement now?

We might have to use tenderly (which is already built-in) instead of [smart-order-router](https://github.com/Uniswap/smart-order-router) its own gas heuristic or any other gas provider in the long term. Gas estimate has become...

It felt like when we were rushing to support `BASE`, couple places were only coded to support `BASE`, but not `BASE_GOERLI`, including this repo and in [smart-order-router](https://github.com/Uniswap/smart-order-router). I wonder if...

I tried a bit from https://github.com/Uniswap/smart-order-router side. It appears BASE_GOERLI doesn't have the liquidity for the WETH/USDbC pools yet, so router side cannot be supported yet. Since it's testnet, we...

@ahsan-javaiid there's some genuine error, sourced from Unit Tests: > 0x6B1a73d547F4009A26B8485b63D7015D248AD406 is not a valid address. > > 658 | > 659 | // Rootstock Tokens > > 660 |...

Couple things needed: 1. caching-token-provider need to add RootStock: https://github.com/Uniswap/smart-order-router/pull/511/files#diff-615bf7538df0e457fdd95bd9c65eacf3c0ff3bb1c410f7ba1162927a8e9e4e79 2. v2 and v3 static-subgraph-provider need to add popular token for pool, as there's no subgraph for rootstock uniswap yet:...