Joshua Thornton comments

Results 11 comments of


                                            Joshua Thornton

Initialize class property that has no initializer with this.prop

Any update on this? It breaks `@lazyInject` from Inversify I have temporarily bypassed it by doing this: ``` constructor(props) { super(props); lazyInject(tokens.ProductActionContainer)(this.__proto__, 'ProductActionContainer'); } ```

directoryListing wrong directory?

Handle errors -- what if `git` is missing or IO fails?

Changing parent UI affects children

I'd love this feature too. Say I have a scene where I want a child component's ui to be different than another scene's child component's ui. You could pass down...

Question: What is the best way to reset ui state on route change?

If you're using `react-router` you can use the `onLeave` or `onEnter` lifecycle method and then call `resetUI` from there.

Should we recalculate UI state when props change?

@tonyhb An option might be to provide another key to the config called `nextState`, which is called on `componentWillUpdate`. Then you can recalculate the state with the new props. The...

There is currently no way to change the tooltip styles

I think making it a pure component is definitely the right way of going about this. It might be good to provide a default one in the repo for people...

Warning: Task "scsslint:allFiles" failed. Use --force to continue.

I agree on this one. The grunt runner should take the severity from scss-lint and determine whether it was successful (albeit with warnings) or unsuccessful due to errors.

Custom Icons

feat: headless functionality in hook

tbh it isn't even a breaking change, as whilst this PR uses the hooks syntax of `use*` there isn't actually any hooks utilised under the hood, so versions < v16.8.0...