Joachim Seminck
Joachim Seminck
I think the reason is that `getFocusPath` exits too early. It checks the range of the `ExportDefaultDeclaration` and decides that, because the current cursor is not within that range (it...
I upgraded babylon7 to the latest beta. It updates the range of the `ClassExpression`, but not of the `DefaultExportExpression`. Not sure yet if this is intended or not. Will find...
That means traversing through the whole node tree on the first "click", and caching everything. And then when the code changes, the cache has to be cleared. Or did I...
I might have some time this weekend to look into it!
I managed to create an alternative `getFocusPath` function that seems to return a valid path. However, the path starts with the "Decorator" node, so the "ExportDefault" and "ClassDeclaration" nodes are...
Just add: `&& cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js` ``` js "test": "node --harmony_proxies node_modules/.bin/jest --coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js", ```
@johnwright thank you for the workaround, it fixed the problem for me as well. Perhaps we can add this to the README? But I don't really know what it means...
There's a PR for the `no-typos` test, so you can actually ignore it. It happened due to a bump in ESLint that caused an unsupported case to be supported.
Hmm, just wondering, Is this still valid with React 16? https://facebook.github.io/react/blog/2017/09/08/dom-attributes-in-react-16.html It seems the data attribute is no longer ignored, but it does get lowercased: https://codesandbox.io/s/6nx6p1r0rn Otherwise looks good to...
I like this rule also. For reference, I have a PR that adds similar functionality to the existing `prefer-stateless-function` rule, but there were a few cases that I didn't manage...