Jacob Selig

Results 18 comments of Jacob Selig

> @jselig-rigetti Please fix the failing test so that we can merge this. Apologies, I'm still working on the fixes - quite a few problems introduced following the linting and...

Isn't `pi` literal always converted into a float per https://github.com/rigetti/quil-rs/pull/240 ?

Current footprint of async in the v4 branch - `api/_abstract_compiler.py`: - `AbstractCompiler` has an `asyncio.AbstractEventLoop` that: - passes to a `CompilerClient` - is used for `quil_to_native_quil` calling to `qcs_sdk` -...

Related, I couldn't get https://github.com/RustCrypto/hashes?tab=readme-ov-file#examples working correctly, had to use the following: ```rs use sha2::{Sha256, Digest}; // from the example // no such associated item (E0599) let digest = Sha256::digest(b"hello");...

> @jselig-rigetti - any good news w/r to fixing the failing tests? > > LMK if there is a way I could help out with this. Apologies, I ended up...

@pavoljuhas thanks for offering to help - I've fixed the format/lint/type/test errors I've found locally, so I believe this should be ready for final review pending feedback on the thread...

I added `pragma: no cover` to all lines that failed the coverage test as part of https://github.com/quantumlib/Cirq/pull/6281/commits/8412760d373cd6eca6ba2802fbbb6e65aa103a88 mostly as a way to show where coverage needed to be added, although...

> The failure of [pytest ubuntu (3.12)](https://github.com/quantumlib/Cirq/actions/runs/9321020588/job/25740499453) appears to be caused by [rigetti/pyquil#1736](https://github.com/rigetti/pyquil/issues/1736). The latest "pyquil==4.10.1" can be installed to Python 3.12.0, but not to 3.12.1 or later. > >...

Yes, I plan to take it on, you could assign it to me 👍