jseba

Results 19 comments of jseba

> Need to add a test case in https://github.com/google/gvisor/blob/master/test/syscalls/linux/rlimits.cc. Can do, forgot about the C++ tests. What test case were you thinking of? That changing the various limits shows up...

It's not taking any physical memory, I'm trying to understand why this huge mapping is needed for Intel processors but not AMD. When gvisor panics/crashes, the coredump routines in the...

If someone gets a chance to take a look at this again, I'd appreciate it! It bubbled up to the top of our ticket tracker to remind me to check...

Apologies for taking so long to get back to this, I rebased and added a simple unit test to read the limits file after changing it via setrlimit

@avagin friendly ping when you get a chance to review again, I'd appreciate it

> @jseba pls merge the fix to the proper commit. Do I rebase it into the unit test commit and force push?

> @jseba yes. We want to have the clean history in the main repo. gotcha, not sure how copybara works but I squashed the unit test fix into its commit,...

If there's a way to get debug logs only when the container is created and not while it executes, I might be able to get something. Otherwise we simply don't...

Okay, finally managed to get some debug logs from the create command, nothing obvious stands out to me. This is from version `release-20230214.0` ``` D0223 13:14:52.814844 3874296 container.go:185] Create container,...

I used SIGUSR2 as the signal that firecracker gets from the OS on its parent's death in case there is anything that needs to be done differently on this path...