Justin Raymond
Justin Raymond
before I proceed in actually fixing the checks and adding some tests, are you actually interested in adding this algorithm to the library?
Hey!! thanks for the suggestions. I will work on them as soon as I get the chance.
Does a reference implementation also not have a value in benchmarks? It gives a baseline that automatically adjusts for improvements in `rustc` or in the library itself.
I agree it should not be in the public API. As far as I can tell, if it is not part of the public API then the tests and the...
I haven't yet implemented your suggestion of using a bitmap. I just ran `perf` on the algorithm and the output confirms the benefit of implementing your suggestion: ``` - 85.81%...
this is waiting on a PR to add the required methods to fixedbitset bluss/fixedbitset#20
Which rustc/compiler flags are you using?
Thanks James. I see about the same speedups: | usize | deviation | u32 | -- | -- | -- | -- | -- bench_insert_range | 3,862 | 416 |...
Thanks for the contribution! I'll take a closer look later. Backwards compatibility is important so `new` no longer being const is definitely a blocker.
@sitegui do you mind clarifying how `into_ones` allows writing `struct IntoIter`?