John Rood

Results 9 comments of John Rood

It seems like the real compatibility issue here is with Ivy, not with Angular 9 or 10.

Indeed https://github.com/angular/material2/pull/7835 would be the way to implement search/filtering. @crisbeto is waiting for feedback before merging, so please give your feedback there if you have any.

@arlowhite What about extending the mat-select to be searchable/filterable while multiple selection is enabled. Does that accomplish the same purpose? There's a pr open for a mat-select-header https://github.com/angular/material2/pull/7835 where you...

@noahpgordon My sincere apologies for the misunderstanding that happened here. We definitely do need this concept entry, parent to the term entries mentioned. I'll coordinate with the team to make...

Indeed, when gtm.js tries to create this iframe, Partytown seems to be proxying this behavior and doing something else (perhaps requesting the iframe src) instead. Since, this src matches `loadScriptsOnMainThread`,...

It's also not clear if `sw_iframe.html` is even necessary. Tags still seem to load without it.

Ok yes, `sw_iframe` seems necessary for running sandboxed code. If Partytown could honor `loadScriptsOnMainThread` for iFrames (as it does currently for scripts), I believe this would resolve the issue.

@muhsin-life, if we understand the core issue here to be that this script is not loading on the main thread when it should be, then the example that @brandonfredericksen included...

@rcxfinearts sorry for the confusion here. Creating the file is part of the work for this issue.