Johannes Rieken

Results 171 comments of Johannes Rieken

@elf-pavlik The progress indication will show the a tree view operation is in progress. And since the tree views is the only thing we support here I was assuming that...

I would go with the more traditional entry in the "View"-menu first, similar to existing action. The pin/unpin icon in breadcrumbs might be seen as noisy for when you don't...

> For both stable and insiders separately, to get windows performance trace (ETW) @deepak1556 The perf machine doesn't run stable the same way it runs insiders. So, it is unlikely...

> I do not really see a trend of slowness in 1.71.x tbh. Me neither but the variation between the days is quite large (1.865 to 1.627 for 1.71)

f5c96, today - https://az764295.vo.msecnd.net/insider/f5c96e2db885f43fe1adb4a6ebbdfecf095430a8/VSCode-win32-x64-1.71.0-insider.zip 13b17, last fast - https://az764295.vo.msecnd.net/insider/13ba7bb446a638d37ebccb1a7d74e31c32bb9790/VSCode-win32-x64-1.70.0-insider.zip 3104d, fast - https://az764295.vo.msecnd.net/insider/3104db414c8fedcf6e4493f14da7df0b7413853a/VSCode-win32-x64-1.70.0-insider.zip --- fast - https://az764295.vo.msecnd.net/insider/9925e5d4d3d355758cd09d26868f0c12a0006828/VSCode-win32-x64-1.70.0-insider.zip slow - https://az764295.vo.msecnd.net/insider/052d5b0027f6c9d64c8ca35955cb5117ba94d5d7/VSCode-win32-x64-1.70.0-insider.zip

🤷 It's really tricky - I manually compared the build from https://github.com/microsoft/vscode/issues/156864#issuecomment-1219546192 on my mac, an arm windonw vm, and the perf machine but I couldn't see a clear trend...

Just looking the perf machine telemetry shows a slow-down between insiders of the 3rd and 5th of August. This is all commits: https://github.com/microsoft/vscode/commits/main?since=2022-08-03&until=2022-08-05. The E19 adoption happened then but also...

@mjbvz I have https://github.com/microsoft/vscode/pull/158892 to revert both changes. In addition to the jsben.ch-numbers is see a slowdown in real world perf, not as drastic but consistent. On my M1 pro...

https://vscodeteam.slack.com/archives/C3NBSM7K3/p1661330838069859 - looks like we pulled back ~30ms with today's insiders. Confirms my assumption about perf differences between my machine 🏃 and the perf bot 👴

> I think this can be implemented, because no action is done when currently dragging the command center Unfortunately not. Once you mark a region as "window-drag-region" it won't receive...