jrahlf

unncessary void in parameter list

1

Hi, some functions have a void parameter instead of an empty parameter list. https://github.com/jnk0le/Ring-Buffer/blob/dade96727256c6d7466f716c54bc3bfca3875952/ringbuffer.hpp#L52

Add template parameter to make it a overwriting ring buffer

1

Hi, how about adding a template parameter which makes it an overwriting ring buffer? I.e. when buffer is full, calling insert() replaces the oldest value with the new value. Then...

Generalize ring buffer, differentiate between atomic ring buffer non-atomic ring buffer

1

Hi, as I understand your ring buffer is targeted for embedded systems, which is exactly what I am using it for. I think it can be even more generalized, by...

Add optimized (smaller) lookup table for float type parsing

2

Reduce code size if only float accuracy is needed for parsing, implements #99 Pro: - reduces binary code size if only `float` type is used for parsing (numbers are discussed...

optimized (smaller) lookup table for float (binary32 only)

6

Have you considered optimizing the code size for parsing floats? The LUT `power_of_five_128` has approximately ~1400 entries which are needed for parsing doubles. I don't know how many entries are...

Add encryption flag

2

- adds encryption flag - update uf2.h: add all flags, also make familyID, fileSize, reserved a union - update readme.md accordingly

Granularity of device ids

1

Hi, what is the granularity of the device ids? Should every chip with a different flash size get its own device id? E.g. there are 6 different versions of the...

- The link to https://github.com/expnkx/fast_io in the top level readme is dead. - Documentation in ryu_parse.h says that `RYU_OPTIMIZE_SIZE` is not supported, but in `s2d.c` it actually uses the large...

Duplicate volatile reads in interrupt handler for adc

2

Similar to #17 , there are unnecessary duplicate volatile reads in the interrupt handler for the adc peripheral. `__HAL_ADC_GET_FLAG` is called several times inside the handler, each time the actual...

Duplicate volatile reads in interrupt handler for hal_timer

2

Similar to #17 , there are unnecessary duplicate volatile reads in the interrupt handler for the timer peripheral. `__HAL_TIM_GET_FLAG` is called several times inside the handler, each time the actual...