Jianqiang Li

> We might need an identity QSFP56_DD to cover all the QSFP56-DD types. The count of optical lanes can be identified by ETHERNET_PMD_TYPE. For instance, TYPE2 corresponds to ETH_400GBASE_FR4, ETH_400GBASE_LR4,...

BTW, could we add more peer identities in a single PR, such as QSFP112, and QSFP112_DD which will be soon commercially available. For each generation of form factor, we are...

> I think there was some desire to specify the types, so keeping with that I'd lean towards adding the Type3 as done here. > > Adding an umbrella QSFP56...

> Actually @jqjqlee would [openconfig/models#1038](https://github.com/openconfig/models/pull/1038) help here? I am afraid not. In PR#1038, we indeed added several FEC monitors which are defined in openconfig-terminal-device. These added FEC monitors are only...

> Hi Leon, after some internal discussion we came to the following recommendation: > > Introduce a new identity of "QSFP56_DD". This should be inclusive of type 1,2,3. Please add...