jposwiata

False negatives with decoding bytes

1

During testing SIGILL I found several instruction which should fail (expected behaviour) don't cause any handling (or SEGV). I noticed, that these instructions are incorrectly decoded by XED, while valid...

Incorrect handling of CRC

2

In CRC and COPY_WITH_CRC commands it is not allowed to set initial CRC values after PAGE_FAULT with no bytes processed. update_crc_for_continuation() and update_copy_crc_for_continuation() should include the conditon: ``` if (crc_record.bytes_completed()...

Incorrect patterns in update_**_for_continuation

1

FILL, to avoid "shifted pattern" on page boundary (I assume that 16B pattern is not handled yet and 8 is OK). ``` uint32_t processed = 8 * (fill_record.bytes_completed() / 8);...

Different wrapping in main pane and diff pane

1

"Wrap lines" option apply to both main pane and differences pane. Is it possible to have lines wrapped in Diff Pane, while not wrapped in main pane? It would be...