Jarek Porzucek
Jarek Porzucek
@rosecodym Changed to allowlist, np!
@nabeelalam ahhh, rookie mistake! Please try again now
Also added support for correct parsing with YAML files that don't end with a newline character. The function now automatically appends `\n` if missing, improving parser compatibility and following POSIX...
@nabeelalam Renamed to `--allowlist-secrets-file` - hope it's more accurate 🤞
@camgunz All requested changes applied! 🙌
> I don't want to throw a wrench in this review, but what about introducing this feature in the `--config` file? https://github.com/trufflesecurity/trufflehog?tab=readme-ov-file#configuration You mean as a new field in [sources](https://github.com/trufflesecurity/trufflehog/blob/466da5b0bb161144f6afca9afe5d57975828c410/pkg/pb/sourcespb/sources.pb.go#L292-L311)?
@zricethezav I've added a top-level `allowlists` so it matches `gitleaks` naming convention. The behavior now is it merges allowlisted secrets from `--config` and `--allowlist-secrets-file` files. I'm not sure what's the...
@zricethezav @nabeelalam @camgunz Can you take a look when you got a chance? 🙏
@nabeelalam @camgunz Can we merge this please? 😁
@kfcampbell Can you take a look at this PR when you have a chance pls? 🙏