John Plaisted

Admittedly I know very little about this as well. AFAIK it is what we use for code splitting internally. Rerouting to @concavelenz @shicks or @brad4d.

We have some lint checks but they aren't strict enough, imo.

Is it worth unblocking this by ignoring the rbs piece of this problem? - Who is currently reading the generated code and expecting it to be readable? - They need...

Oh, you don't even need the interface to reproduce, so it has nothing to do with `override`. My mistake! ```ruby # typed: strict require 'sorbet-runtime' module MyTracer def instrument(name) proxy...

I think this will break using mock clock to tick promises in tests. When you have an async test (returns a thenable) then the test framework will use `goog.Promise` to...

Then you get into different timing issues. `MockClock` forces `goog.Promise` to use next tick to schedule, rather than native `Promise`. It never undoes this action. Even if we did make...

You're right, I wasn't clear sorry. But upon further investigation I was incorrect anyway. I thought what was happening was `MockClock` forced `goog.Promise`s to use macrotasks, but if the test...

Hey, sorry for the delayed response! Do you mean specifically issues with modules (e.g. mocking out modules), or just unit testing in general (e.g. how to use junit / assertions...

Personal thoughts: There's a more general problem that our mocking framework isn't type checkable. If it was, then having the compiler type check your tests would catch this. If we...

Closure's base.js file must either be under a `root`, specified as a `file`, or you can avoid passing in the actual file if you give it the `closure-path` argument. I...