Joris Pelgröm

Results 333 comments of Joris Pelgröm

> > Should the name format be aligned with core? At first glance, it appears to be [`UUID major.minor`](https://github.com/home-assistant/core/blob/a495df9759ee973620690ee8083d73181547934c/homeassistant/components/ibeacon/coordinator.py#L65) if no specific name is set instead of `UUID-major-minor`. > >...

Another race condition? Guess the changes in #2855 weren't enough... I'm tempted to just remove the `!!` to prevent crashes.

Managed to reproduce this by introducing an artificial delay [right before this line](https://github.com/home-assistant/android/blob/8713bb9678a967d69932dd0b85e34428ce1385fa/common/src/main/java/io/homeassistant/companion/android/common/data/websocket/impl/WebSocketRepositoryImpl.kt#L241). I'm not sure how realistic it is, but the flow isn't removed anywhere else. The device would...

> I don't really see a way for us to validate these custom protocols that are defined by the app themselves, android does not have a native way to detect...

I hadn't thought about how to implement it yet :) Now that I think about it this probably isn't going to work correctly anyway because it won't work for broadcasts...

Is 'App links' the correct name for what it is supporting? The [documentation](https://developer.android.com/training/app-links) (also linked in docs PR) describes them as "web links that use the HTTP and HTTPS schemes...

Technically the documentation describes "_Android_ App Links" so you're not wrong but it is somewhat confusing as a developer... Agreed we should focus on the user though, so updating the...

The latest changes break deep links for me, whereas previously it worked correctly. Example using Google Clock app ```yaml service: notify.mobile_app_pixeldev data: message: test data: actions: - action: URI title:...

> So it's taking you to the market for deep links? Or nowhere? It opened the Play Store with a screen "Something went wrong / Try again". Unfortunately it looks...

> I imagine you see the same behavior in WebViewActivity? The markdown card seems to filter the links out so I can't test it easily 😅 but I assume it'll...