Jolyon Pawlyn

Results 11 comments of Jolyon Pawlyn

Hi, thanks for the response. The config file is as follows: ``` ruby #Goldberg configuration Project.configure do |config| # config.ruby = '1.9.2' # Your server needs to have rvm installed...

Good point and apologies, this certainly doesn't count as an issue. Was just wanting to highlight the problem that came up a week ago for those who use your login...

Afraid I'm unable to share but happy to take a look at your's if you would like to email it to me at gmail (jpawlyn).

Just realised that the problem with inheriting from `ActiveJob::QueueAdapters::AbstractAdapter` is that the test will only pass with active job 7.2 but not sure how to do update the test to...

> Just realised that the problem with inheriting from `ActiveJob::QueueAdapters::AbstractAdapter` is that the test will only pass with active job 7.2 but not sure how to do update the test...

> hmm reading through https://github.com/rails/rails/pull/53375/files and I'm a little stumped on the recommended path for Shoryuken users. > > For rails 8 will not be an issue. For rails 7.2...

> @jpawlyn instead of inheriting, you could maybe `include ActiveJob::Enqueuing` if it makes things simpler? Not sure but interested to know more @januszm

> Hi @jpawlyn > > I'm sorry, it was not introduced by your pull request (main is also failing), but can you also fix the CI errors? No worries, happy...

> Looking great! Thank you @jpawlyn for the contribution! > > Good to merge after adding some tests I haven't been able to re-create the issue in the Avo test...

@Paul-Bob I tried writing a test but unfortunately it doesn't fail with the original code. Somehow my app running in production and the activestorage test suite re-creates the issue but...