Josiah Vinson
Josiah Vinson
Linking #1451 which is a fuller explanation of the issue this PR would like to address.
According to [DICOM's response](https://www.dicomstandard.org/docs/librariesprovider2/dicomdocuments/wp-cotent/uploads/2019/05/faq-dicom-128-byte-preamble-posted1-1.pdf) makes the point that this mainly affects DICOMWeb services: "DICOM images read from media and sent over the network using DICOM protocols (C-Store, C-Move, C-Get) have...
This is the most current guidance in the standard: https://dicom.nema.org/medical/dicom/current/output/chtml/part10/sect_7.5.html Basically, it's up to the application to decide the appropriate action. It seems like it would be pretty straightforward for...
@mrbean-bremen looked again and you're right, the reader skips the preamble and the writer writes a blank preamble. I think we should close this issue and if dual format content...
Thanks, @gofal for the quick reply. I guess my overall point is that we should communicate to the end user what the default behavior is, so if we're keeping the...
@gofal thanks for the clarification - you're right, there are so many tradeoffs to balance in API design. Unfortunately, almost everyone has a different solution! What do you think about...
@brandonpollett 👋
Hi @benjaminirving - as noted [in the documentation,](https://github.com/microsoft/dicom-server/blob/bd3fa7c1d2fbfc1eab2b37537284205edda21772/docs/how-to-guides/configure-dicom-server-settings.md#ohif-viewer) we do include the OHIF viewer as a default feature. There are many different viewers in the DICOM ecosystem, so our strategy...
Looks like there's an issue with the regex capture group for tenant - I've encountered the same problem.
Thanks for the explanation, and it completely makes sense to me. The challenge is that building a general DicomWeb implementation as we are doing involves both sets of data -...