jostar-yang

Results 10 comments of jostar-yang

I check sonic_xcvr code and there is no sff-8438 lib. Will sonic_xcvr support sff-8438 in the future?

> @jostar-yang Would this change fix [sonic-net/sonic-buildimage#12675](https://github.com/sonic-net/sonic-buildimage/issues/12675) ? If yes, please mention it in the description. Yes. The PR is for https://github.com/sonic-net/sonic-buildimage/issues/12675

The driver ,i2c-imc.c, support ddr sensors for Broadwell CPU machine. It is i2c bus driver. When probe i2c-imc.c, jc42 will be probed ,too. Then, we will see 0x18 and 0x1a...

Modify sys_led in pddf-device.json. Refer to below PDDF framework PR. https://github.com/sonic-net/sonic-buildimage/pull/13475 https://github.com/sonic-net/sonic-buildimage/pull/13476 https://github.com/sonic-net/sonic-buildimage/pull/13477 https://github.com/sonic-net/sonic-buildimage/pull/13474

We create new PR for this one. Close the old PR. https://github.com/sonic-net/sonic-buildimage/pull/24028

Modify sys_led define. Refer to below PDDF framework PR, https://github.com/sonic-net/sonic-buildimage/pull/13475 https://github.com/sonic-net/sonic-buildimage/pull/13476 https://github.com/sonic-net/sonic-buildimage/pull/13477 https://github.com/sonic-net/sonic-buildimage/pull/13474

We create new PR for this case. So close old PR. https://github.com/sonic-net/sonic-buildimage/pull/23737