Joshua Lambert

Results 136 comments of Joshua Lambert

Hi @Bisaloo , @alexskeels, & @vboussange. Firstly, thank you @vboussange for the comments. I will use the specific comments to improve the package. @alexskeels Apologies for not replying sooner. I...

@Bisaloo Thanks, I completely agree. I was going to mention the conflict of interest in the next week or so. Once again thank you to @vboussange and @alexskeels for your...

This issue might also link with the {linelist} package and whether there is a line list standard from that package and whether any of the columns are grouped. If so...

I've addressed the comment on inheriting documentation in ff399d1ccc2566196fa70d97763e863e93a4fa67. Currently, `...` is not used by any function, so I was a bit confused by: > to pass variables via `...`...

@sbfnk this can be closed now #78 is merged.

Thanks @sbfnk for raising this, and thanks @Bisaloo for posting a solution. I've chosen to use the same approach as epiverse-trace/linelist#125 in PR #314.

Thanks for posting @adamkucharski and for sharing the copilot proposed changes. I've updated to `as_epidist()` and `epireview_to_epidist()` (which is internal and called by `as_epidist()`) in PR #335 to implement the...

Closing this issue now PR #335 is merged into `main`.

Thanks @sbfnk this looks great. I'm happy to move forward with this change and merge into `main`. A couple of points before merging. 1. When I checked that the pkgdown...

> presumably e.g. on CRAN the table wouldn't be rendered either I wasn't sure whether it would render on CRAN, according to this page I think it does: https://cran.r-project.org/web/packages/DT/vignettes/DT.html. I'll...