Josh Chuang

Results 8 comments of Josh Chuang

@KUAN-HSUN-LI thanks for the review. 1. Yes. The outputs are now properly formatted and can be seen at Actions > Check Style > View raw logs. Do ctrl+F for `.github`...

Actually, I can't quite find a YAML formatter that supports helm syntax. I'm tempted to leave autoformat for a future issue and limit this one to linting.

Another issue I found is that [Prettier](https://prettier.io/), which is used in `submarine-cloud-v2/`, will always break linting for multiline flow sequences (the `[]` list). An example would be line 64 of...

The one thing that prettier (and yamllint) fails to parse is the `{{-` `-}}` syntax, so it won't work with `helm-charts/submarine/charts/traefik/templates/deployment.yaml` for example. Other than that, we could switch yamllint...

It seems that `yq` doesn't and won't support helm syntax either. In [its issue #636](https://github.com/mikefarah/yq/issues/636) it's mentioned that support is impossible. I'll limit this PR to just a YAML linter....

Upon discussion, we concluded that helm syntax support and auto-formatting are still desired. Can we put this PR on hold for now?

@cdmikechen The check on `submarine-server` is passing now, thank you. For the changes in the CR, right now there are no test cases for them. I'll change the test cases...