joshualitt

Results 10 comments of joshualitt

@jakemac53 , I know you can't give a thorough review, I'm sending this to your desk mostly as FYI.

RE: the typing discrepancy, even though we will only have one type for all JS functions(`JSFunction`), I think the overall behavior will be much safer with JS types because Dart...

Whoops, I just realized that `bindUnaryCallbackGuarded` doesn't return a `Future` does it? The `expectAsync` threw me off. How does this code involve asynchronous logic without explicitly involving `Future`s at some...

Disowning this for now, until https://github.com/google-gemini/gemini-cli/issues/12099 is fixed. I have a PR to prefer ripgrep from the system path(https://github.com/google-gemini/gemini-cli/pull/11847), but it makes sense to pull in checksum verification logic into...

@guidedways , this is on our radar. It's actually a bit more complicated then we'd have liked due to the need to do checksum verification, and to do that we...

@jacob314 , thoughts on the UI side of this? By default, we get a simple box with the summary from the agent.

@CN-Scars , thank you for the PR! This is indeed a good idea, and it looks like it's going in the right direction. I left some feedback already, but at...

@CN-Scars , thanks! This PR is looking very close, just one comment to work through and I think we'll be there.

@CN-Scars , thanks for your patience! This looks great now, modulo my question on `logout`, which I think is the last detail to sort out, and we'll be ready to...

@CN-Scars , hmm, I think we may want to add a right margin or somethin? The right edge of the box seems to touch the scrollbar.