Joshua Mühlfort
Joshua Mühlfort
Removing "WIP" status, as implementation of this feature is basically complete/ready for review (except of tests which I would write if this approach is considered viable). Implementing any alternative approach...
@maelvls > Does it look good to you @joshmue? It does, thank you very much! One thing I did not mention in the call today, IIRC: Currently, [in this PR](https://github.com/joshmue/cert-manager/blob/2e9c1bd00de3cc1e640bcff77426e4782c8816ad/internal/vault/vault.go#L330),...
> l'll make the mentioned changes, try to rebase the PR and try to write some tests. Did that. PR is ready for review, now.
@maelvls Anything left to do for me here?
/remove-lifecycle stale (even though I probably need to do a fresh rebase soon)
Setting WIP while rebasing...
Rebase done. Removing WIP.
@maelvls Were you able to take a further look yet? If there is something I can do to move this forward, I'd be happy to do so.
Thanks for the review! I'll attempt to address these issues one after another.
> I looked into the feasibility of an e2e test, and it seems totally feasible. I pushed an example of what the e2e could look like: joshmue/cert-manager@vault_client_cert_auth...maelvls:cert-manager:vault_client_cert_auth_tests > > To...