Josh B
Josh B
Absolutely, should be easier with aio
Same as #1591. See the answer there too: https://github.com/codeceptjs/CodeceptJS/issues/1591#issuecomment-480800333 You need to return some garbage value from `fetch`, e.g. just add `fetch: () => "whatever"` after `check`.
I recovered the "expected" behavior with only a few small changes to `search.js` (marked in comments) ```javascript class Search extends BaseCommand { // ... async exec (args) { const opts...
Nice job :)
You can work around this by running ```shell eask eval '(progn (load-file "./my-test.el") (ert-run-tests-batch-and-exit))' ```
Seems like a few alternatives for fixes: 1. add a flag e.g. `eask--preserve-error-p` just for when errors should be propagated and use it in `ert.el` ```elisp (defun eask--error (fnc &rest...
Hmm, perhaps it's to do with emacs version? I'm on 31.0.50. I'll see what happens when using other versions. Edit: Ok seems like it works for 28 and 29, but...
Ok so the "why" is in https://github.com/emacs-mirror/emacs/commit/fe0f15dbc962b37d98507a494fd7720bad584a7a In summary, ert previously bound `debug-on-error` while running, but now doesn't (since v30). Hence `eask--error` will not raise the error. It seems this...
Ok some of the strange ways it breaks... Because `(error "x")` is defined as `(signal 'error "x")`, not all errors are stopped by the advice, just errors that are created...
Cheers! Will do. On Sat, 2 Nov 2024, 00:59 Jen-Chieh Shen, ***@***.***> wrote: > Yeah, I think your solution is much cleaner! Would you like to open a PR >...