Jory Cunningham

Results 10 comments of Jory Cunningham

> PR title is a bit misleading and does not represent what the code is technically doing. The code is removing the `href` from the last breadcrumb which just happens...

I see, thank you for the explanation @michaeldowseza . I've updated the PR title and unit test logic.

@pan-kot I've added comments per your suggestion. In terms of automated testing, I think a dedicated HTML validator, run globally, would be more effective than AXE here. Might we consider...

@jnurthen great question. I should have specified that I tested this on latest version of the following: - Firefox (Mac + WIndows) - Chrome (Mac + WIndows) - Edge (Windows)...

Yes, I was thinking since the behavior I'm describing seems pervasive that we might want to establish it as the norm in the keyboard interaction and perhaps have the note...

@JAWS-test thanks for your thoughts on that. I don't have any data to say which model is more usable and I personally think both are defensible as a practice. My...

@mcking65 pardon my ignorance but is the behavior being inconsistent from browser to browser a bug or is it just inconsistency? Which is to say is there some standard that...

I've renamed the prop `errorIconAriaLabel` and moved it into `i18nStrings` per @timogasda

> @jorycunningham it is necessary to add errorIconAriaLabel to fix a11y failures, as you did for Flashbar. @YueyingLu yes. In this case it is an instance of the error icon...

@YueyingLu @avinashbot I've updated this PR based on our conversations, specifically: * Change css element selectors that rely on the HTML structure of AbstractSwitch to use spans, not divs *...