Joris Zwart
Joris Zwart
- [x] I guess it depends on #1079 to have successful checks.
I have implemented write and seek support. As far as I'm concerned, this pull request is ready for further review. Thanks so far.
I was tempted to implement the `io.ReaderAt` and `io.WriterAt` interfaces as well, but clients can do that themselves by combining `io.Reader` (or `io.Writer`) and `io.Seeker`: ```Golang type Foo struct {...
By the way, I'm ok with you making your desired changes so we can close this. That might be more efficient? If you agree?
Can you be more specific about what's confusing about it?
Wild guess: try setting the store's `MaxLength` property to something large. It defaults to 4096 bytes (which may not be enough). ```Go store.MaxLength = 10 * 1024 ``` Edit: I...
The Linux builds with *libsqlite3* fail with: ``` === RUN TestBlobRead blob_io_test.go:46: no such vfs: memdb --- FAIL: TestBlobRead (0.00s) ``` I don't know how to fix this.
@rittneje do you agree with the proposed fix?
@rittneje Is there anything I can do to get this approved?
> @joriszwart I am away from my dev machine or I'd just add those two `len` checks myself. They should be pretty simple to add. Can you add them?