Joris Roovers

Results 138 comments of Joris Roovers

Related: A `general.ignore-fixup-amend-commits=True` option telling gitlint to ignore these amend commits by default. Will implement this as part of this issue.

> I would group them, as I do not see why anyone (any maintainer) ever would want to keep a "squash" message, but not a "fixup" message (or the other...

Sorry for the delay, I didn't press submit on my code review from last week apparently. And here I was thinking I was waiting for you!

The confusing error message is because we don’t have `__repr__` implemented, I created #321 to fix that. The real error was that you were using rule-id `CC1` instead of `CC2`...

> Sure! As this is quite a large PR, I will do a rebase and clean up the history and then we can merge this 🎉 Not needed! I squash...

We can add this as a [contrib rule](https://jorisroovers.com/gitlint/contrib_rules/). I’ve quickly implemented this a user-defined rule. Can you please verify this works as expected? ```python # filename: captilized_title.py from gitlint.rules import...

AFAIK, that’s only the case in Python 2, not python 3. See below: ```python $ python Python 3.10.2 (main, Feb 13 2022, 14:37:03) [GCC 9.3.0] on linux Type "help", "copyright",...

> And I forgot to mention, that we are running Gitlint on Windows 10 machines. This might be clue! Gitlint has known issues with unicode on Windows; it's complicated (see...

Ok, thanks for the debug output. The fact that Notepad++ is giving the same result seems to indicate *"it's complicated"* and not just a gitlint specific issue. I will keep...